Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all RedisClientTypes #141

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Support all RedisClientTypes #141

merged 4 commits into from
Oct 12, 2023

Conversation

dominik-cnx
Copy link
Collaborator

In our project we want to use the REPLICATION mode (and not CLUSTER). With this PR we allow to use all 4 RedisClientTypes. If STANDALONE is used in your project then this change is backward compatible.

/**

  • Define what kind of behavior is expected from the client.
    */
    @VertxGen
    public enum RedisClientType {

/**

  • The client should work in single server mode (the default).
    */
    STANDALONE,

/**

  • The client should work in sentinel mode. When this mode is active
  • use the {@link RedisRole} to define which role to get the client
  • connection to.
    */
    SENTINEL,

/**

  • The client should work in cluster mode. When this mode is active
  • use the {@link RedisReplicas} to define when replica nodes can be
  • used for read only queries.
    */
    CLUSTER,

/**

  • The client should work in replication mode. When this mode is active
  • use the {@link RedisReplicas} to define when replica nodes can be
  • used for read only queries.
    */
    REPLICATION
    }

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fd0925a) 63.59% compared to head (2833f45) 63.59%.
Report is 9 commits behind head on develop.

❗ Current head 2833f45 differs from pull request most recent head 13745b5. Consider uploading reports for the commit 13745b5 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #141      +/-   ##
=============================================
- Coverage      63.59%   63.59%   -0.01%     
- Complexity       382      386       +4     
=============================================
  Files             32       32              
  Lines           2409     2428      +19     
  Branches         291      294       +3     
=============================================
+ Hits            1532     1544      +12     
- Misses           721      727       +6     
- Partials         156      157       +1     
Files Coverage Δ
...wisspush/reststorage/util/ModuleConfiguration.java 81.01% <68.75%> (-2.78%) ⬇️
...rg/swisspush/reststorage/DefaultRedisProvider.java 59.77% <72.72%> (+3.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominik-cnx dominik-cnx merged commit 22ba675 into develop Oct 12, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants