[pdf] Improve performance with transient states #16606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redisplaying pdf pages can be slow. Similar to how it is already disabled for minibuffer prompts (see the implementation of `pdf-view-maybe-redisplay-resized-windows`), do not redisplay when entering a transient state and while it is active. Note that after exiting a transient state redisplay will be done if necessary. This makes a difference when `pdf-view-display-size` is `fit-height`, or when resizing windows using the window transient state.
smile13241324
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redisplaying pdf pages can be slow. Similar to how it is already disabled for minibuffer prompts (see the implementation of
pdf-view-maybe-redisplay-resized-windows), do not redisplay when entering a transient state and while it is active. Note that after exiting a transient state redisplay will be done if necessary.This makes a difference when
pdf-view-display-sizeisfit-height, or when resizing windows using the window transient state.Addresses #16517.