fixes to error reporting string formats (#255)

CMakeLists.txt

@@ -142,6 +142,11 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND
     message(FATAL_ERROR "Silice requires g++ 8 at least")
 endif()
 
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror=format -Werror=format-security")
+endif()
+
+
 set(STD_FS_LIB "")
 # ==== The test below is based on https://github.com/pybind/pybind11/blob/master/tests/CMakeLists.txt
 # It is under a BSD-style license, see https://github.com/pybind/pybind11/blob/master/LICENSE

src/Algorithm.cpp

@@ -6295,7 +6295,7 @@ void Algorithm::checkExpressions(const t_instantiation_context &ictx,antlr4::tre
       if (A != m_InstancedBlueprints.end()) { // algorithm?
         Algorithm *alg = dynamic_cast<Algorithm*>(A->second.blueprint.raw());
         if (alg == nullptr) {
-          reportError(sourceloc(async), "called instance '%s' is not an algorithm", async->IDENTIFIER()->getText().c_str());
+          reportError(sourceloc(sync), "called instance '%s' is not an algorithm", sync->joinExec()->IDENTIFIER()->getText().c_str());
         } else {
           // if parameters are given, check, otherwise we allow call without parameters (bindings may exist)
           if (!sync->callParamList()->expression_0().empty()) {
@@ -6333,7 +6333,7 @@ void Algorithm::checkExpressions(const t_instantiation_context &ictx,antlr4::tre
       if (A != m_InstancedBlueprints.end()) { // algorithm?
         Algorithm *alg = dynamic_cast<Algorithm*>(A->second.blueprint.raw());
         if (alg == nullptr) {
-          reportError(sourceloc(async), "joined instance '%s' is not an algorithm", async->IDENTIFIER()->getText().c_str());
+          reportError(sourceloc(join), "joined instance '%s' is not an algorithm", join->IDENTIFIER()->getText().c_str());
         } else {
           // if parameters are given, check, otherwise we allow call without parameters (bindings may exist)
           if (!join->callParamList()->expression_0().empty()) {

src/LuaPreProcessor.cpp

@@ -1055,7 +1055,7 @@ void LuaPreProcessor::decomposeSource(
       if (w == "unit" || w == "algorithm" || w == "algorithm#" || w == "circuitry") {
         std::string name = parser.readString("( \t\r");
         if (name.empty()) {
-          throw Fatal((w + " has no name").c_str()); // TODO: improve error report (line)
+          throw Fatal("%s",(w + " has no name").c_str()); // TODO: improve error report (line)
         }
         cerr << "functionalizing " << w << ' ' << name << '\n';
         if (w == "algorithm#") {