Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _config.yml for customizable title, description #59

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fix _config.yml for customizable title, description #59

merged 1 commit into from
Mar 22, 2018

Conversation

ryanking13
Copy link
Contributor

On #17, @frigaut asked about how to change the site's title, since it always shows a same description "Simplistic, responsive jekyll based open source theme", and you said it's not yet customizable.

I fixed _config.yml so that jekyll-seo-tag can automatically generates site's custom title and description properly.


In _includes/head.html, actually there is a code that generates site's custom title and description from _config.yml's theme_settings:title, theme_settings:title but it's manually disabled by commenting out 4 months ago.

    <!-- Manual seo tags -->
    <!--
    <title>{% if page.title %}{{ page.title }} |{% endif %} {{ site.theme_settings.title }}</title>
    <meta name="description" content="{% if page.excerpt %}{{ page.excerpt | strip_html | strip_newlines | truncate: 160 }}{% else %}{{ site.theme_settings.description }}{% endif %}">
    -->

I'm not sure you intended that for later implementation, if you did, please ignore this PR.

@sylhare
Copy link
Owner

sylhare commented Mar 22, 2018

Indeed, thanks ;)

@sylhare sylhare merged commit 11088f2 into sylhare:master Mar 22, 2018
OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this pull request Dec 8, 2020
[C#] remove extra word in CLI.md
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this pull request Oct 5, 2021
Fix _config.yml for customizable title, description
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this pull request Mar 8, 2022
Fix _config.yml for customizable title, description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants