Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open issues for missing config reference #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 5, 2020

Currently for FrameworkBundle, DebugBundle, SecurityBundle, TwigBundle and WebProfilerBundle.

#SymfonyHackday

Blocked by symfony/symfony#39334 and symfony/symfony#39328

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still blocked? Do we need to upgrade dependencies?

Also, it strikes me that this may be more useful as a dashboard that is up-to-date and can be checked than something where we create issues each time we find something missing - basically like your translations dashboard.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 10, 2020

Is this still blocked? Do we need to upgrade dependencies?

Nope, it is not blocked any more.

We dont need to bump dependencies. The CI job will checkout master of Symfony/symfony.

Also, it strikes me that this may be more useful as a dashboard that is up-to-date and can be checked than something where we create issues each time we find something missing - basically like your translations dashboard.

I agree. Im also happy to make the translation dashboard part of Carson. The issue with having only a dashboard, is that we get multiple issue trackers.

Anyhow, dashboard or not, I think this PR is a good first step.

@OskarStark
Copy link
Contributor

Very nice @Nyholm could you add a new test-repo, run the command and create the potential newly created issues there? In this case we can double check if everything went well and don't bother all the symfony-docs users ?

@Nyholm
Copy link
Member Author

Nyholm commented Jan 6, 2021

Sure. Here is an issue generated by this script. It is for Framework bundle
carsonbot-playground/symfony#13

Other bundles are at:
carsonbot-playground/symfony#14
carsonbot-playground/symfony#16
carsonbot-playground/symfony#17

@Nyholm
Copy link
Member Author

Nyholm commented Jan 6, 2021

I see that the XML dumper is not including "Examples" or "Prototype".

That will make our output very different. See the Security bundle.
carsonbot-playground/symfony#19
carsonbot-playground/symfony#16

@OskarStark
Copy link
Contributor

Is this still needed ?

@Nyholm
Copy link
Member Author

Nyholm commented Sep 16, 2024

It is a nice feature to tell us where we have missing documentation. .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants