Add support for symfony/webpack-encore-bundle
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
feat/webpack-encore-bundle
branch
from
f25dcca
to
2cd2420
Compare
OskarStark
approved these changes
Oct 27, 2024
OskarStark
reviewed
Nov 13, 2024
| @@ -23,6 +23,7 @@ SYMFONY_DOCS_SECRET='' | |||
| SYMFONY_SECRET='' | |||
| SYMFONY_UX_SECRET='' | |||
| SYMFONY_WEBPACK_ENCORE_SECRET='' | |||
| SYMFONY_WEBPACK_ENCORE_BUNDLE_SECRET='' | |||
There was a problem hiding this comment.
@fabpot I guess the secret needs to be set.
Can you please do it and merge this PR? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #237, but for https://github.com/symfony/webpack-encore-bundle.
For the time being, and given the state of the project, adding CarsonBot will be useful for notifying new-PR authors if maintainers can't modify their PR.
I also plan to add the PR template soon.
Things to do at post-merge:
SYMFONY_WEBPACK_ENCORE_BUNDLE_SECRETenvironment variable in platform.shThanks