Switch partial templates to anonymous Twig components #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
feature/component-html-syntax
branch
from
509bae1
to
b3d8913
Compare
|
Thanks for this proposal. Before continuing working on this PR, let's ask JS/UX experts like @weaverryan, @kbond and @stof about this. My non-expert opinion is divided. I think it's very obvious that making a UX component for search is correct ... but making an "empty" UX component just to display the post contents looks a bit "unnatural" for a Symfony app. It could confuse users about what's the traditional/common way of working in Symfony apps to display entity contents. Let's wait for more opinions. Thanks! |
|
FYI, once symfony/ux#802 is available, the empty component class will no longer be required. |
ker0x
changed the title
ker0x
force-pushed
the
feature/component-html-syntax
branch
from
c012300
to
f7fdf0a
Compare
ker0x
force-pushed
the
feature/component-html-syntax
branch
from
f7fdf0a
to
55a0c7e
Compare
|
@javiereguiluz, @kbond I've updated my PR to convert all partial templates into anonymous Twig components! |
stof
reviewed
Sep 8, 2023
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposed to switch to the HTML syntax for components. It also introduce a new
PostComponentcomponent