Simplify logout #1459
Merged
Simplify logout #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function logout(): void | ||
| { | ||
| throw new \Exception('This should never be reached!'); | ||
| } |
There was a problem hiding this comment.
Still might be good for newcomers? It explains how the feature works internally
There was a problem hiding this comment.
The problem is that this "fake" logout route always felt weird for newcomers and created friction. I think it's better to just forget about this. If someone needs to do something advanced related to logout, they'll just find plenty of information about this in the Symfony Docs. Thanks!
There was a problem hiding this comment.
Yeah, probably makes sense 👍
javiereguiluz
force-pushed
the
sf64_features
branch
from
4438086
to
10277e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the list of Symfony 6.4 features, and this is the only one that I think it fits this application. So, let's use it.