Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the composer cache from the CI workflows #1551

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Jan 2, 2025

I think there is little benefit anymore for this repository to have a composer cache in the CI workflows. With composer v2 the dependencies are downloaded in parallel which is a lot faster than composer v1. This makes the performance gains from the cache small since it also takes time to setup and save or restore the cache.

Also the chance for a cache hit is low:

  • This repository has low traffic and the cache expires after a week which reduces the chance for a cache hit.
  • Every branch / PR get it's own cache which again reduces the chance for a cache hit.

So I purpose to remove the composer cache to simplify the workflows.

Replaces: #1538

@javiereguiluz
Copy link
Member

I like this. I recently found out that the GitHub cache is per PR, but we'd need a global cache for vendor/ dir that it's shared by everyone and that only changes the the composer.lock file changes. It's not possible to do that, so let's remove the cache entirely. Thanks!

@javiereguiluz javiereguiluz merged commit db2c20e into symfony:main Jan 3, 2025
6 checks passed
@rosier rosier deleted the ci-remove-cache branch January 3, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants