Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid version string "9999999.9999999" #1029

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

nicolas-grekas
Copy link
Member

Fix #887
Fix #983
Fix #1016

@nicolas-grekas
Copy link
Member Author

I'm not sure why we end up with 9999999.9999999 in symfony.lock but at least this works around it.
The issue is that composer accepts max 5 digits for the major version.
I'm not sure because in Downloader.php, we append .9999999, but I don't see where we prefix by 9999999

@nicolas-grekas nicolas-grekas merged commit bda5f86 into 1.x Oct 7, 2024
7 of 8 checks passed
@nicolas-grekas nicolas-grekas deleted the fix9999999 branch October 7, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant