Skip to content

Commit

Permalink
Merge branch '6.3' into 6.4
Browse files Browse the repository at this point in the history
* 6.3:
  skip tests that do not work with ICU 71.1
  • Loading branch information
xabbuh committed Nov 30, 2023
2 parents b3f597c + 5afc733 commit 10649ab
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions Tests/Extension/Core/Type/DateTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Symfony\Component\Form\ChoiceList\View\ChoiceView;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Intl\Intl;
use Symfony\Component\Intl\Util\IntlTestHelper;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;

Expand Down Expand Up @@ -94,6 +95,10 @@ public function testSubmitFromSingleTextDateTime()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -116,6 +121,10 @@ public function testSubmitFromSingleTextDateTimeImmutable()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -139,6 +148,10 @@ public function testSubmitFromSingleTextString()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -161,6 +174,10 @@ public function testSubmitFromSingleTextTimestamp()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -185,6 +202,10 @@ public function testSubmitFromSingleTextRaw()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand Down

0 comments on commit 10649ab

Please sign in to comment.