Cast boolean env variables

symfony · Oct 3, 2024 · e706dc9 · e706dc9
1 parent 6a9f089
commit e706dc9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/ProcessManager/ChromeManager.php b/src/ProcessManager/ChromeManager.php
@@ -97,19 +97,19 @@ private function getDefaultArguments(): array
         $args = [];
 
         // Enable the headless mode unless PANTHER_NO_HEADLESS is defined
-        if (!($_SERVER['PANTHER_NO_HEADLESS'] ?? false)) {
+        if (!(filter_var($_SERVER['PANTHER_NO_HEADLESS'] ?? false, FILTER_VALIDATE_BOOLEAN))) {
             $args[] = '--headless';
             $args[] = '--window-size=1200,1100';
             $args[] = '--disable-gpu';
         }
 
         // Enable devtools for debugging
-        if ($_SERVER['PANTHER_DEVTOOLS'] ?? true) {
+        if (filter_var($_SERVER['PANTHER_DEVTOOLS'] ?? true, FILTER_VALIDATE_BOOLEAN)) {
             $args[] = '--auto-open-devtools-for-tabs';
         }
 
         // Disable Chrome's sandbox if PANTHER_NO_SANDBOX is defined or if running in Travis
-        if ($_SERVER['PANTHER_NO_SANDBOX'] ?? $_SERVER['HAS_JOSH_K_SEAL_OF_APPROVAL'] ?? false) {
+        if (filter_var($_SERVER['PANTHER_NO_SANDBOX'] ?? $_SERVER['HAS_JOSH_K_SEAL_OF_APPROVAL'] ?? false, FILTER_VALIDATE_BOOLEAN)) {
             // Running in Travis, disabling the sandbox mode
             $args[] = '--no-sandbox';
         }

diff --git a/src/ProcessManager/FirefoxManager.php b/src/ProcessManager/FirefoxManager.php
@@ -92,12 +92,12 @@ private function getDefaultArguments(): array
         $args = [];
 
         // Enable the headless mode unless PANTHER_NO_HEADLESS is defined
-        if (!($_SERVER['PANTHER_NO_HEADLESS'] ?? false)) {
+        if (!(filter_var($_SERVER['PANTHER_NO_HEADLESS'] ?? false, FILTER_VALIDATE_BOOLEAN))) {
             $args[] = '--headless';
         }
 
         // Enable devtools for debugging
-        if ($_SERVER['PANTHER_DEVTOOLS'] ?? true) {
+        if (filter_var($_SERVER['PANTHER_DEVTOOLS'] ?? true, FILTER_VALIDATE_BOOLEAN)) {
             $args[] = '--devtools';
         }
 

diff --git a/src/ServerTrait.php b/src/ServerTrait.php
@@ -35,7 +35,7 @@ private function stopWebServer(): void
     private function pause($message): void
     {
         if (\in_array('--debug', $_SERVER['argv'], true)
-            && ($_SERVER['PANTHER_NO_HEADLESS'] ?? false)
+            && (filter_var($_SERVER['PANTHER_NO_HEADLESS'] ?? false, FILTER_VALIDATE_BOOLEAN))
         ) {
             echo "$message\n\nPress enter to continue...";
             if (!$this->testing) {

diff --git a/tests/ServerExtensionTest.php b/tests/ServerExtensionTest.php
@@ -44,7 +44,7 @@ public function testPauseOnFailure(string $method, string $expected): void
 
         // stores current state
         $argv = $_SERVER['argv'];
-        $noHeadless = $_SERVER['PANTHER_NO_HEADLESS'] ?? false;
+        $noHeadless = filter_var($_SERVER['PANTHER_NO_HEADLESS'] ?? false, FILTER_VALIDATE_BOOLEAN);
 
         self::startWebServer();
         $_SERVER['argv'][] = '--debug';