fix: allow content to be empty when calling Crawler::html() method #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl20b
force-pushed
the
fix-type-error-when-html-content-is-empty
branch
from
1aab6ca
to
8a5d56d
Compare
|
@nicolas-grekas @dunglas is it ok for you? |
dunglas
approved these changes
Feb 27, 2024
OskarStark
approved these changes
Feb 28, 2024
dunglas
requested changes
Feb 28, 2024
dunglas
requested changes
Feb 28, 2024
dunglas
approved these changes
Feb 28, 2024
|
Thank you @syl20b! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope that will fix the #615.
Regards,
Sylvain