[Feature] Add WaitForClickable helper #635
Conversation
| * @throws NoSuchElementException | ||
| * @throws TimeoutException | ||
| */ | ||
| public function waitForClickable(string $locator, int $timeoutInSecond = 30, int $intervalInMillisecond = 250): PantherCrawler |
There was a problem hiding this comment.
$timeoutInSecond -> $timeoutInSeconds ?
same for $intervalInMillisecond -> $intervalInMilliseconds ?
There was a problem hiding this comment.
I thought this was a little weird too, but this is the way its done for all the other cases as well.
Cant change it for the other cases either, as thats a BC. We keep it like this so they're the same, or adjust this one?
There was a problem hiding this comment.
I see. The same arguments in other methods are indeed named in the same way you did.
Changing the argument names can be made in other PR if wanted. By the way, Symfony's BC promise doesn't cover argument names, so we can change them if we decide it's better to do so. See https://symfony.com/doc/current/contributing/code/bc.html#note-10
Thanks
There was a problem hiding this comment.
Awesome, TIL!
I think its best to change all the names in a seperate PR in that case :)
No description provided.