Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only in prod #1580

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Only in prod #1580

merged 1 commit into from
Jan 5, 2024

Conversation

OskarStark
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 5, 2024 07:39
Copy link

github-actions bot commented Jan 5, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1580/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1580/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'datana-gmbh/logz-io-handler:^1.7'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

datana-gmbh/logz-io-handler

1.0 vs 1.7
diff --git a/datana-gmbh/logz-io-handler/1.0/config/packages/datana_logz_io_handler.yaml b/datana-gmbh/logz-io-handler/1.7/config/packages/datana_logz_io_handler.yaml
index 8d358916..70b84759 100644
--- a/datana-gmbh/logz-io-handler/1.0/config/packages/datana_logz_io_handler.yaml
+++ b/datana-gmbh/logz-io-handler/1.7/config/packages/datana_logz_io_handler.yaml
@@ -1,13 +1,14 @@
-services:
-    _defaults:
-        autowire: true
+when@prod:
+    services:
+        _defaults:
+            autowire: true
 
-    Inpsyde\LogzIoMonolog\Handler\LogzIoHandler:
-        arguments:
-            $token: '%env(LOGZ_IO_TOKEN)%'
-            $host: 'listener-eu.logz.io'
+        Inpsyde\LogzIoMonolog\Handler\LogzIoHandler:
+            arguments:
+                $token: '%env(LOGZ_IO_TOKEN)%'
+                $host: !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1
 
-    Datana\LogzIo\Handler\Logger\Processor\AddApplicationNameProcessor:
-        arguments:
-            - '%env(LOGZ_IO_APPLICATION_NAME)%'
-        tags: ['monolog.processor']
+        Datana\LogzIo\Handler\Logger\Processor\AddApplicationNameProcessor:
+            arguments:
+                - '%env(LOGZ_IO_APPLICATION_NAME)%'
+            tags: ['monolog.processor']

@OskarStark OskarStark requested review from fabpot and Nyholm January 5, 2024 07:40
@OskarStark OskarStark disabled auto-merge January 5, 2024 07:42
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm removed the request for review from fabpot January 5, 2024 08:12
@OskarStark OskarStark merged commit c2e85bc into symfony:main Jan 5, 2024
1 of 2 checks passed
@OskarStark OskarStark deleted the update-recipe branch January 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants