Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebpackEncoreBundle] Update recipe for Webpack Encore 5 #1341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WebpackEncoreBundle] Update recipe for Webpack Encore 5 #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions symfony/webpack-encore-bundle/2.0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
"devDependencies": {
"@babel/core": "^7.17.0",
"@babel/preset-env": "^7.16.0",
"@symfony/webpack-encore": "^4.0.0",
"core-js": "^3.23.0",
"@symfony/webpack-encore": "^5.0.0",
"core-js": "^3.38.0",
"regenerator-runtime": "^0.13.9",
"webpack": "^5.74.0",
"webpack-cli": "^4.10.0",
"webpack-cli": "^5.1.0",
"webpack-notifier": "^1.15.0"
},
"license": "UNLICENSED",
Expand Down
2 changes: 1 addition & 1 deletion symfony/webpack-encore-bundle/2.0/post-install.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

* Compile your assets: <fg=green>npm run dev</>

* Or start the development server: <fg=green>npm run watch</>
* Or start the development server: <fg=green>npm run dev-server</>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for keeping watch as the default suggestion as it works out of the box while dev-server requires installing an additional dependency.

2 changes: 1 addition & 1 deletion symfony/webpack-encore-bundle/2.0/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Encore
// enables and configure @babel/preset-env polyfills
.configureBabelPresetEnv((config) => {
config.useBuiltIns = 'usage';
config.corejs = '3.23';
config.corejs = '3.38';
})

// enables Sass/SCSS support
Expand Down
Loading