[Workflow] Add Doctrine type information for multiple state marking stores

[Tiriel]

Just experienced the behavior described inside the tip box (alongside @Spomky ):

When mapping a workflow array-marking store into Doctrine with the type simple_array and it contains only one key-value pair, the data stored is the value only as a string, resulting in a loss of the current place. Workflow checks then raises exception as the current place is interpreted as 0.

This aims to prevent anyone else frommaking the same mistake, following advice from @nicolas-grekas

[OskarStark]

Suggested change

	Inside a multiple state marking store, places are store as keys with
	Inside a multiple state marking stored, places are store as keys with

[Tiriel]

Not sure about this, I'm talking about the marking_store object.
Going to try for another way to say this, like "Inside a multiple-state marking_store" ?

[OskarStark]

Couldn't this be fixed on the code-side @lyrixx ?

This sounds like a bug to me

[lyrixx]

Couldn't this be fixed on the code-side @lyrixx ?

nope, the number of token can be superior to 1

[Tiriel]

Couldn't this be fixed on the code-side @lyrixx ?

nope, the number of token can be superior to 1

And checking about with Doctrine's simple_array type, it's also its intended behavior. simple_array converts arrays to text using a simple implode, so keys are obviously lost. A small documentation on the issue would still be a good idea IMHO.

[Tiriel]

Btw, what should I do with the lint error? Remove the import completely?

[javiereguiluz]

I like this contribution, but this comment is a bit confusing to me:

Type declaration is not mandatory ...

But in the paragraph above we're saying that we need to store this in a JSON type of column.

[Tiriel]

That's true. I was trying to say that JSON is the default type inferred by Doctrine, and so one should either not declare any type, or explicitly declare Json type, but not the simple_array. How would you phrase that in a simpler way?

[javiereguiluz]

Maybe we could remove the comment and just use the JSON type explicitly in the example. Experienced folks can omit the type if they know that Doctrine will guess it for them.

[javiereguiluz]

Thanks Benjamin!