Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] ServiceSubscriberTrait is deprecated and replaced by ServiceMethodsSubscriberTrait #19767

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Apr 9, 2024

Fix #19755
Related code change: symfony/symfony#54496

@carsonbot carsonbot added this to the 7.1 milestone Apr 9, 2024
@GromNaN GromNaN force-pushed the ServiceMethodsSubscriberTrait branch 2 times, most recently from f5b8464 to 8825bd7 Compare April 9, 2024 13:02
@GromNaN GromNaN force-pushed the ServiceMethodsSubscriberTrait branch from 8825bd7 to f17331c Compare April 10, 2024 08:36
@carsonbot carsonbot changed the title ServiceSubscriberTrait is deprecated and replaced by ServiceMethodsSubscriberTrait [DependencyInjection] ServiceSubscriberTrait is deprecated and replaced by ServiceMethodsSubscriberTrait Apr 10, 2024
@javiereguiluz javiereguiluz merged commit 9892599 into symfony:7.1 Apr 10, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Jérôme!

Wouter was right that we don't document deprecations like this. However, when we change a class/trait/method name in some Symfony version, we add a message mentioning the previous name. So, I added that while merging. See 078d6f9

@GromNaN GromNaN deleted the ServiceMethodsSubscriberTrait branch April 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contracts] Rename ServiceSubscriberTrait to ServiceMethodsSubscriberTr…
4 participants