feat(when constraint): add context variable #20314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrYamous
reviewed
Oct 13, 2024
Comment on lines
+166
to
167
| Depending on how you use the constraint, you have access to 1 or 3 variables | ||
| in your expression: |
There was a problem hiding this comment.
Suggested change
| Depending on how you use the constraint, you have access to 1 or 3 variables | |
| in your expression: | |
| Depending on how you use the constraint, you have access to different variables | |
| in your expression: |
To match with text in doc for Expression constraint, "to 1 or 3 variables" doesn't feel clear to me
There was a problem hiding this comment.
What about « multiple internal variables »
MrYamous
reviewed
Oct 13, 2024
Comment on lines
+174
to
+175
| ``context`` | ||
| This is the context that is used in validation |
There was a problem hiding this comment.
Could you add a versionadded directive for this new variable ?
There was a problem hiding this comment.
We need to improve this description. Right now it's basically saying "context is the validation context" 😐
For example, in the Validation article (https://symfony.com/doc/current/validation.html) the word context is not even mentioned once. So, what's the "validation context"? Any article that we could link from here so readers can learn more? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20312