[Messenger] Add a tip about using make:messenger-middleware
#20337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrYamous
reviewed
Oct 19, 2024
| @@ -2836,6 +2836,11 @@ and a different instance will be created per bus. | |||
| $bus->middleware()->id('App\Middleware\AnotherMiddleware'); | |||
| }; | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| If you have installed the Maker bundle, you can use the ``make:messenger-middleware`` command | |||
There was a problem hiding this comment.
Suggested change
| If you have installed the Maker bundle, you can use the ``make:messenger-middleware`` command | |
| If you have installed the MakerBundle, you can use the ``make:messenger-middleware`` command |
Cosmetic but I have the impression to see it written this way most of the time in documentation
And we may can add link to bundle documentation too
There was a problem hiding this comment.
I didn't find a way to link to the bundle documentation (see first commit). So I checked some other pages and often there was no link to the bundles pages.
There was a problem hiding this comment.
Done this change while merging. Thanks!
OskarStark
changed the title
make:messenger-middleware
carsonbot
changed the title
make:messenger-middlewaremake:messenger-middleware
javiereguiluz
force-pushed
the
patch-3
branch
from
703d04b to
9f26f64
Compare
|
@alsciende thanks for your contribution. This was finally merged! |
xabbuh
added a commit
that referenced
this pull request
Feb 4, 2025
* 7.2: [#20337] fix typo Replace left over "annotation" by "attribute"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tip about using make:messenger-middleware to create custom Middlewares, because it's easy to skip the importance of the "$stack->next()->handle($envelope, $stack)" line. Might save someone's time.