Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Object Mapper] Add component #20347

Open
wants to merge 4 commits into
base: 7.2
Choose a base branch
from
Open

Conversation

soyuka
Copy link
Contributor

@soyuka soyuka commented Oct 24, 2024

Documents the object mapper component from

@carsonbot carsonbot added this to the 7.2 milestone Oct 24, 2024
@OskarStark OskarStark changed the title [Object Mapper] component introduction [Object Mapper] Add component Oct 24, 2024
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Oct 24, 2024
@carsonbot carsonbot modified the milestones: 7.2, next Oct 24, 2024
object-mapper.rst Outdated Show resolved Hide resolved
object-mapper.rst Outdated Show resolved Hide resolved
object-mapper.rst Outdated Show resolved Hide resolved
object-mapper.rst Outdated Show resolved Hide resolved
object-mapper.rst Outdated Show resolved Hide resolved
Co-authored-by: Tomas Norkūnas <[email protected]>
Co-authored-by: Oskar Stark <[email protected]>
Comment on lines +108 to +110
/**
* @implements CallableInterface<Source>
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary in a documentation example ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that its best to have a copy/paste that doesn't trigger phpstan errors

// src/Dto/Source.php
namespace App\Dto;

use App\ObjectMapper\TransformNameCallable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use statement doesn't seem used in this example

object-mapper.rst Outdated Show resolved Hide resolved
Using the ObjectMapper Service
------------------------------

Once enabled, the object mapper service can be injected in any service where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once installed ?

because writing enabled can mean that it is not enabled:usable by default after installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants