Add more information about core team processes #20720
Open
+117
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
commented
Mar 4, 2025
wouterj
force-pushed
the
contributing-docs
branch
2 times, most recently
from
4d0ae9d to
632493a
Compare
Kocal
approved these changes
Mar 4, 2025
Kocal
reviewed
Mar 4, 2025
smnandre
reviewed
Mar 5, 2025
smnandre
reviewed
Mar 5, 2025
fabpot
requested changes
Mar 5, 2025
wouterj
force-pushed
the
contributing-docs
branch
from
632493a to
75c0c32
Compare
There was a problem hiding this comment.
Wouter, thanks a lot for contributing these improvements. Thanks to reviewers too.
I like everything except this change:
"minor change" --> "peripheral change"
Minor is self-explanatory and everybody is used to it. Peripheral is an euphemism that needs to be explained in order to know exactly what it refers to. I don't think "minor" is offensive or problematic at all. Some changes, some work, some ideas, etc. are minor compared to others. I think that's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.