[Messenger] Keepalive support for Doctrine & Redis #20721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Mar 4, 2025
Comment on lines
-1748
to
-1750
| The keepalive feature, which prevents messages from being prematurely redelivered during | ||
| long-running processing, updates the ``delivered_at`` timestamp periodically to ensure | ||
| the message is marked as "in progress". |
There was a problem hiding this comment.
I don't think this is needed since no other transport has an explanation of how the keepalive mechanism is implemented and I'm not sure it's even relevant.
There was a problem hiding this comment.
While this is an implementation detail, it could be helpful to understand the how, that said, its ok for me to remove it.
There was a problem hiding this comment.
Maybe we could add a similar explanation for each transport that has the keepalive mechanism implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keepalive support for the Doctrine and Redis transports was added in symfony/symfony#59601 and symfony/symfony#59360, respectively.