-
-
Notifications
You must be signed in to change notification settings - Fork 315
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix non scalar value to anonymous component
- Loading branch information
matheo
committed
Aug 8, 2023
1 parent
02ae73b
commit 665638c
Showing
6 changed files
with
38 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?php | ||
|
||
namespace Symfony\UX\TwigComponent\Tests\Fixtures; | ||
|
||
class User | ||
{ | ||
public function __construct( | ||
private readonly string $name, | ||
private readonly string $email, | ||
) {} | ||
|
||
public function getName(): string | ||
{ | ||
return $this->name; | ||
} | ||
|
||
public function getEmail(): string | ||
{ | ||
return $this->email; | ||
} | ||
} |
1 change: 1 addition & 0 deletions
1
src/TwigComponent/tests/Fixtures/templates/anonymous_component_none_scalar_prop.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<twig:UserCard :user='user'/> |
4 changes: 4 additions & 0 deletions
4
src/TwigComponent/tests/Fixtures/templates/components/UserCard.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<div class='user-card'> | ||
<p>{{ user.name }}</p> | ||
<p>{{ user.email }}</p> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
namespace Symfony\UX\TwigComponent\Tests\Integration; | ||
|
||
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; | ||
use Symfony\UX\TwigComponent\Tests\Fixtures\User; | ||
use Twig\Environment; | ||
|
||
/** | ||
|
@@ -182,6 +183,16 @@ public function testRenderAnonymousComponentInNestedDirectory(): void | |
$this->assertStringContainsString('class="primary"', $output); | ||
} | ||
|
||
public function testRenderAnonymousComponentWithNonScalarProps(): void | ||
{ | ||
$user = new User('Fabien', '[email protected]'); | ||
|
||
$output = self::getContainer()->get(Environment::class)->render('anonymous_component_none_scalar_prop.html.twig', ['user' => $user]); | ||
|
||
$this->assertStringContainsString('Fabien', $output); | ||
$this->assertStringContainsString('[email protected]', $output); | ||
} | ||
|
||
private function renderComponent(string $name, array $data = []): string | ||
{ | ||
return self::getContainer()->get(Environment::class)->render('render_component.html.twig', [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters