Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComponentAttributes constructor typehint and remove @internal #1027

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix ComponentAttributes constructor typehint and remove @internal #1027

merged 1 commit into from
Aug 15, 2023

Conversation

norkunas
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Tickets Fix #304
License MIT

I heavily rely on ComponentAttributes instantiation in components to be able to use same logic on all component elements, for example:

<div{{ attributes.defaults({ ... })>
  <img{{ imageAttributes.defaults({ ... })>
</div>

In the issue it was proposed to rename ComponentAttributes but I don't see the point to break the code for people now 🙂

WebMamba
WebMamba approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am agree here 😁

@weaverryan
Copy link
Member

Thanks @norkunas!

@weaverryan weaverryan merged commit ced15b6 into symfony:2.x Aug 15, 2023
35 of 36 checks passed
@norkunas norkunas deleted the fix-typehint branch August 15, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebMamba WebMamba WebMamba approved these changes

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ComponentAttributes everywhere in project
4 participants
@norkunas @weaverryan @kbond @WebMamba