[TwigComponent] Improve exception message when component not found #1031
Conversation
|
Should we list all components in case it didn't find any alternatives? 🙂 |
|
I'm thinking no. I don't think the Symfony code base does that. |
norkunas
force-pushed
the
exception-mkay
branch
from
da3b611
to
43769c7
Compare
norkunas
force-pushed
the
exception-mkay
branch
from
43769c7
to
eeef204
Compare
|
Rebased |
| $lev = levenshtein($lowerName, $lowerType); | ||
|
|
||
| if ($lev <= $nameLength / 3 || str_contains($lowerType, $lowerName)) { | ||
| $alternatives[] = $type; | ||
| } |
There was a problem hiding this comment.
What about low cost check first instead of doing both?
| $lev = levenshtein($lowerName, $lowerType); | |
| if ($lev <= $nameLength / 3 || str_contains($lowerType, $lowerName)) { | |
| $alternatives[] = $type; | |
| } | |
| if (str_contains($lowerType, $lowerName)) { | |
| $alternatives[] = $type; | |
| } elseif (levenshtein($lowerName, $lowerType) <= $nameLength / 3) { | |
| $alternatives[] = $type; | |
| } |
There was a problem hiding this comment.
Are you going to get this exception all the time? 🙂
|
|
||
| $message .= implode('", "', $alternatives).'"?'; | ||
| } else { | ||
| $message .= ' And no matching anonymous component template was found.'; |
There was a problem hiding this comment.
Nice! Just tried it out, it's super useful! Do you think we can apply the Levenshtein to look also for AnonymousComponent?
There was a problem hiding this comment.
🤔 probably all available twig templates then should be iterated :)
There was a problem hiding this comment.
As I'm not using anonymous components, then I'll leave it for you as that was your feature :)
|
This is great - thanks Tomas! |
I have over 150 components and to me it's just useless to list all component names in exception message and to look for the right name in a very long list.
Used same code to get alternatives like in Symfony codebase.