Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigComponent] Remove 3 futures deprecations (minor) #1118

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? no
License MIT

Fix deprecations

Framework

1x: Since symfony/framework-bundle 6.4: Not setting the "framework.handle_all_throwables" config option is deprecated. It will default to "true" in 7.0.
1x in ComponentFactoryTest::testTwigComponentServiceTagWithoutKeyButCollissionCausesAnException from Symfony\UX\TwigComponent\Tests\Integration

1x: Since symfony/framework-bundle 6.4: Not setting the "framework.php_errors.log" config option is deprecated. It will default to "true" in 7.0.
1x in ComponentFactoryTest::testTwigComponentServiceTagWithoutKeyButCollissionCausesAnException from Symfony\UX\TwigComponent\Tests\Integration

PHPUnit

1) Symfony\UX\TwigComponent\Tests\Unit\TwigPreLexerTest::testPreLex
Data Provider method Symfony\UX\TwigComponent\Tests\Unit\TwigPreLexerTest::getLexTests() is not static

@smnandre
Copy link
Member Author

Fixed the previous fail (handle_all_throwable does not exist before Symfony 6.2)

The new one (phpcs) is fixed in #1122

@weaverryan
Copy link
Member

Thanks Simon!

@weaverryan weaverryan merged commit c1c19b9 into symfony:2.x Sep 18, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants