Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StimulusBundle][Doc] Mention removeComments will no longer be necessary #2347

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

MatTheCat
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues N/A
License MIT

Once #2304 is released, it will no longer be necessary to set removeComments to false when using TypeScript, because the stimulusFetch: 'lazy' comment will be searched in the source rather than the compiled content.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 7, 2024
@Kocal
Copy link
Member

Kocal commented Nov 7, 2024

Thank you @MatTheCat.

@Kocal Kocal merged commit 33d1c8d into symfony:2.x Nov 7, 2024
2 checks passed
@MatTheCat MatTheCat deleted the stimulus-bundle_typescript_comment branch November 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer StimulusBundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants