[Map] Introduce ux_map.google_maps.default_map_id configuration
#2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
Kocal
commented
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
Comment on lines
+84
to
+90
| ->set($rendererFactoryName = 'ux_map.renderer_factory.'.$name, $bridge['renderer_factory']) | ||
| ->parent('ux_map.renderer_factory.abstract') | ||
| ->tag('ux_map.renderer_factory'); | ||
|
|
||
| if ('google' === $name) { | ||
| $container->services() | ||
| ->get($rendererFactoryName) |
There was a problem hiding this comment.
Not a big fan of variables in service names (just personal taste here)
smnandre
approved these changes
Nov 7, 2024
carsonbot
added
Status: Reviewed
smnandre
reviewed
Nov 9, 2024
| 'map' => (clone $map), | ||
| ]; | ||
| yield 'with default map id, when passing options (except the "mapId")' => [ | ||
| 'expected_renderer' => '<div data-controller="symfony--ux-google-map--map" data-symfony--ux-google-map--map-provider-options-value="{"apiKey":"my_api_key"}" data-symfony--ux-google-map--map-view-value="{"center":{"lat":48.8566,"lng":2.3522},"zoom":12,"fitBoundsToMarkers":false,"options":{"mapId":DefaultMapId,"gestureHandling":"auto","backgroundColor":null,"disableDoubleClickZoom":false,"zoomControlOptions":{"position":22},"mapTypeControlOptions":{"mapTypeIds":[],"position":14,"style":0},"streetViewControlOptions":{"position":22},"fullscreenControlOptions":{"position":20}},"markers":[],"polygons":[]}"></div>', |
There was a problem hiding this comment.
Suggested change
| 'expected_renderer' => '<div data-controller="symfony--ux-google-map--map" data-symfony--ux-google-map--map-provider-options-value="{"apiKey":"my_api_key"}" data-symfony--ux-google-map--map-view-value="{"center":{"lat":48.8566,"lng":2.3522},"zoom":12,"fitBoundsToMarkers":false,"options":{"mapId":DefaultMapId,"gestureHandling":"auto","backgroundColor":null,"disableDoubleClickZoom":false,"zoomControlOptions":{"position":22},"mapTypeControlOptions":{"mapTypeIds":[],"position":14,"style":0},"streetViewControlOptions":{"position":22},"fullscreenControlOptions":{"position":20}},"markers":[],"polygons":[]}"></div>', | |
| 'expected_renderer' => '<div data-controller="symfony--ux-google-map--map" data-symfony--ux-google-map--map-provider-options-value="{"apiKey":"my_api_key"}" data-symfony--ux-google-map--map-view-value="{"center":{"lat":48.8566,"lng":2.3522},"zoom":12,"fitBoundsToMarkers":false,"options":{"mapId":"DefaultMapId","gestureHandling":"auto","backgroundColor":null,"disableDoubleClickZoom":false,"zoomControlOptions":{"position":22},"mapTypeControlOptions":{"mapTypeIds":[],"position":14,"style":0},"streetViewControlOptions":{"position":22},"fullscreenControlOptions":{"position":20}},"markers":[],"polygons":[]}"></div>', |
There was a problem hiding this comment.
Seems to be the cause of the failing checks
There was a problem hiding this comment.
Yes IK, I didn't have time to continue
There was a problem hiding this comment.
But yeah that's was it! This issue was different from the local issue because the Google bridge had dependency on UX Map from packagist (without the tapOptions thing). A symbolic link and applying your patch fixed the issue.
Kocal
added a commit
that referenced
this pull request
Nov 10, 2024
….default_map_id` (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Map][Google] Add documentation about `ux_map.google_maps.default_map_id` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> I've just tilted that I've missed to document the new feature introduced in #2350 for #2306 Commits ------- 18d7b6b [Map][Google] Add documentation about ux_map.google_maps.default_map_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this modification, I can configure a default Google Maps
mapId:without having to manually pass the
mapIdwhen creating aMap: