-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Twig] Cache template class resolution #2364
Conversation
Arf.... again LiveComponent hidden contract .. :( Will fix later |
Cannot reproduce locally :( |
0acc77c
to
8623c61
Compare
Weird. I think is it related to property accessor but it’s weird this différence between local and CI. |
Locally, is your |
Ok i confirm... the Live test helper does not simulate real conditions. But i think we can deal with it :) This was the change responsible for failures 🤷 + if (!$componentMetadata->isAnonymous()) {
// set data that wasn't set in mount on the component directly
foreach ($data as $property => $value) {
if ($this->propertyAccessor->isWritable($component, $property)) {
$this->propertyAccessor->setValue($component, $property, $value);
unset($data[$property]);
}
}
+ } |
Fabbot wrong, we can move on with this one :) |
a25e440
to
75a2997
Compare
Cache template class during rendering.
Non negligeable impact on pages with many components.