Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Allow configuring TomSelect’s labelField #2382

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Autocomplete] Allow configuring TomSelect’s labelField #2382

wants to merge 1 commit into from

Conversation

MatTheCat
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Issues Fix #2375
License MIT

@carsonbot carsonbot added Autocomplete Feature New Feature Status: Needs Review Needs to be reviewed labels Nov 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Autocomplete
controller.js 15.04 kB / 3.62 kB 15.26 kB+1% 📈 / 3.66 kB+1% 📈

Kocal
Kocal approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Autocomplete Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Support labelField options
3 participants
@MatTheCat @Kocal @carsonbot