[StimulusBundle] Marking only the AssetMapper integration as experimental #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 29, 2023
chalasr
reviewed
May 29, 2023
src/StimulusBundle/README.md
Outdated
| This bundle adds integration between Symfony, Stimulus and Symfony UX: | ||
|
|
||
| - A) Twig `stimulus_*` functions & filters to add Stimulus controllers, actions & targets in your templates; | ||
| - B) Integration with Symfony UX & AssetMapper; | ||
| - B) Integration with Symfony UX & AssetMapper (this integration is **experimental**) |
There was a problem hiding this comment.
It could be worth making experimental point to https://symfony.com/doc/current/contributing/code/experimental.html
stof
reviewed
May 29, 2023
src/StimulusBundle/doc/index.rst
Outdated
| This bundle adds integration between Symfony, `Stimulus`_ and Symfony UX: | ||
|
|
||
| A) Twig `stimulus_*` functions & filters to add Stimulus controllers, actions & targets in your templates; | ||
| B) Integration with Symfony UX & AssetMapper; | ||
| - B) Integration with Symfony UX & AssetMapper (this integration is **experimental**) |
There was a problem hiding this comment.
the change at the beginning of the line looks wrong
weaverryan
force-pushed
the
stimulus-partially-experimental
branch
from
c1f1e01
to
7f414c8
Compare
weaverryan
force-pushed
the
stimulus-partially-experimental
branch
from
7f414c8
to
71abb6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StimulusBundle should not really be experimental. The
stimulus_*Twig functions were ported from WebpackEncoreBundle and should work the same (if they don't, that would be a bug).The only part that should be experimental is the AssetMapper integration.
Cheers!