Bugfix - wasn't saving runs

This is what happens when DDB condition strings rely on field names.
symphoniacloud · Nov 20, 2024 · 2529053 · 2529053
1 parent ab82175
commit 2529053
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/app/domain/entityStore/entities/GithubLatestWorkflowRunEventEntity.ts b/src/app/domain/entityStore/entities/GithubLatestWorkflowRunEventEntity.ts
@@ -45,9 +45,9 @@ export async function putRunEventIfNoKeyExistsOrNewerThanExisting(
   event: GithubWorkflowRunEvent
 ) {
   return await store(entityStore).put(event, {
-    conditionExpression: 'attribute_not_exists(PK) OR #updatedAt < :newUpdatedAt',
-    expressionAttributeNames: { '#updatedAt': 'updatedAt' },
-    expressionAttributeValues: { ':newUpdatedAt': event.runEventUpdatedAt }
+    conditionExpression: 'attribute_not_exists(PK) OR #runEventUpdatedAt < :newRunEventUpdatedAt',
+    expressionAttributeNames: { '#runEventUpdatedAt': 'runEventUpdatedAt' },
+    expressionAttributeValues: { ':newRunEventUpdatedAt': event.runEventUpdatedAt }
   })
 }
 

diff --git a/src/app/domain/entityStore/entities/GithubWorkflowRunEntity.ts b/src/app/domain/entityStore/entities/GithubWorkflowRunEntity.ts
@@ -60,9 +60,9 @@ export async function putGithubWorkflowRunfNoKeyExistsOrNewerThanExisting(
   event: GithubWorkflowRunEvent
 ) {
   return await store(entityStore).put(event, {
-    conditionExpression: 'attribute_not_exists(PK) OR #updatedAt < :newUpdatedAt',
-    expressionAttributeNames: { '#updatedAt': 'updatedAt' },
-    expressionAttributeValues: { ':newUpdatedAt': event.runEventUpdatedAt }
+    conditionExpression: 'attribute_not_exists(PK) OR #runEventUpdatedAt < :newRunEventUpdatedAt',
+    expressionAttributeNames: { '#runEventUpdatedAt': 'runEventUpdatedAt' },
+    expressionAttributeValues: { ':newRunEventUpdatedAt': event.runEventUpdatedAt }
   })
 }
 

diff --git a/test/testSupport/fakes/tableRecordExpectedWrites.ts b/test/testSupport/fakes/tableRecordExpectedWrites.ts
@@ -99,12 +99,12 @@ export function expectedPutGithubWorkflowRun(event: GithubWorkflowRunEvent) {
       ...event
     },
     {
-      ConditionExpression: 'attribute_not_exists(PK) OR #updatedAt < :newUpdatedAt',
+      ConditionExpression: 'attribute_not_exists(PK) OR #runEventUpdatedAt < :newRunEventUpdatedAt',
       ExpressionAttributeNames: {
-        '#updatedAt': 'updatedAt'
+        '#runEventUpdatedAt': 'runEventUpdatedAt'
       },
       ExpressionAttributeValues: {
-        ':newUpdatedAt': event.runEventUpdatedAt
+        ':newRunEventUpdatedAt': event.runEventUpdatedAt
       }
     }
   )
@@ -122,12 +122,12 @@ export function expectedPutLatestGithubWorkflowRunEvent(event: GithubWorkflowRun
       ...event
     },
     {
-      ConditionExpression: 'attribute_not_exists(PK) OR #updatedAt < :newUpdatedAt',
+      ConditionExpression: 'attribute_not_exists(PK) OR #runEventUpdatedAt < :newRunEventUpdatedAt',
       ExpressionAttributeNames: {
-        '#updatedAt': 'updatedAt'
+        '#runEventUpdatedAt': 'runEventUpdatedAt'
       },
       ExpressionAttributeValues: {
-        ':newUpdatedAt': event.runEventUpdatedAt
+        ':newRunEventUpdatedAt': event.runEventUpdatedAt
       }
     }
   )