-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Generic DB for listener #2129
Use Generic DB for listener #2129
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/relayer-rebalance #2129 +/- ##
================================================================
+ Coverage 48.54257% 48.55833% +0.01576%
================================================================
Files 372 371 -1
Lines 27720 27711 -9
Branches 83 83
================================================================
Hits 13456 13456
+ Misses 12875 12859 -16
- Partials 1389 1396 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Like submitter uses a generic db for listener.
I was unable to test this since #2101 contains a fix for go 1.22 (I'm using this locally) (see: grafana/pyroscope-go#86 for details)
Wanted to wait for you to merge master into #2073 before wrapping this, but you get the idea. No need to redo db migrations, etc. Just plug & play the "services" (listener, submitter) & if user wants to override the behavior they can