bug: recover zero value check in Height to fix integration-test bug

synapseweb3 · Jul 28, 2023 · ec09d2e · ec09d2e
1 parent ff43572
commit ec09d2e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/crates/relayer-types/src/core/ics02_client/height.rs b/crates/relayer-types/src/core/ics02_client/height.rs
@@ -45,11 +45,9 @@ impl Height {
 
 impl Height {
     pub fn new(revision_number: u64, revision_height: u64) -> Result<Self, Error> {
-        // FIXME: Axon solidity contract allows `revision_height` to be 0 to skip some checks
-        //
-        // if revision_height == 0 {
-        //     return Err(Error::invalid_height());
-        // }
+        if revision_height == 0 {
+            return Err(Error::invalid_height());
+        }
 
         Ok(Self {
             revision_number,

diff --git a/crates/relayer/src/chain/axon/contract/mod.rs b/crates/relayer/src/chain/axon/contract/mod.rs
@@ -5,6 +5,7 @@ pub use generate::*;
 mod contract_generator {
     use ethers::contract::Abigen;
 
+    #[ignore = "generated file cannot be used until mannully fixing compile errors"]
     #[test]
     fn generate_rs() {
         Abigen::new(