Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare ckb4ibc packet test #280

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Conversation

ashuralyk
Copy link
Contributor

@ashuralyk ashuralyk commented Aug 1, 2023

fixed: #257

according to the work of packet test between Axon endpoints, I complete some part of Ckb4Ibc endpoint to fit its packet test for an upcoming use, and currently leaves features to do on below:

  • arrangement of the ckb transaction assembly
  • check the correctness of some other query interfaces, like query_packet_commitment and so on
  • work on the missing feature of packet transaction assembly especially for the unordered channel status

@ashuralyk ashuralyk force-pushed the feat/packet-between-axon-axon branch 2 times, most recently from 9506159 to 9515584 Compare August 7, 2023 05:16
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from ed92e3b to 6a52c27 Compare August 8, 2023 00:21
@ashuralyk ashuralyk changed the base branch from feat/packet-between-axon-axon to dev August 8, 2023 00:22
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from 6a52c27 to 57c2ebe Compare August 15, 2023 02:40
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch 2 times, most recently from da1e350 to 7d12172 Compare August 15, 2023 12:48
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from 7d12172 to 4b41e2f Compare August 15, 2023 14:08
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from f166ade to a164ab3 Compare August 16, 2023 05:51
@ashuralyk ashuralyk marked this pull request as ready for review August 17, 2023 06:14
@ashuralyk
Copy link
Contributor Author

ashuralyk commented Aug 17, 2023

@Flouse the refactored ibc-ckb-contracts has passed the test, and the complete transaction assembly process in inc-packet layer has finished

p.s. packet layer leaves taking advantage of useless WriteAck packet cell to do

@ashuralyk
Copy link
Contributor Author

ashuralyk commented Aug 21, 2023

@Flouse @jjyr @blckngm checklist of this PR has been done and it's better to start a review before this PR comes too big

@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from 7e317e5 to 2897c76 Compare August 21, 2023 12:12
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from 2897c76 to c8b4ae2 Compare August 21, 2023 14:48
@ashuralyk ashuralyk force-pushed the feat/prepare-ckb4ibc-packet-test branch from 834a0d3 to 756b188 Compare August 22, 2023 01:43
@ashuralyk ashuralyk added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit d2aa9e8 Aug 22, 2023
30 checks passed
@ashuralyk ashuralyk deleted the feat/prepare-ckb4ibc-packet-test branch August 22, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants