Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ibc-test/README.md #322

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update ibc-test/README.md #322

merged 2 commits into from
Sep 5, 2023

Conversation

Flouse
Copy link
Collaborator

@Flouse Flouse commented Sep 4, 2023

Description

  1. The testing framework always opens an empty client/connection/channel on chain B side to force the chain B use xxx-1 name instead of xxx-0, it is for catching bugs.

I don't understand this statement very well,
so I've added my thoughts, please correct me if I am wrong.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.

@Flouse Flouse requested a review from jjyr September 4, 2023 15:32
@jjyr
Copy link
Collaborator

jjyr commented Sep 5, 2023

LGTM, I removed the redundant sentence.

@jjyr jjyr added this pull request to the merge queue Sep 5, 2023
Merged via the queue into dev with commit 53c797f Sep 5, 2023
24 of 29 checks passed
@blckngm blckngm deleted the docs-ibc-test-readme branch December 8, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashuralyk ashuralyk ashuralyk approved these changes

@jjyr jjyr jjyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flouse @jjyr @ashuralyk