Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sync with axon new start commands #333

Merged
merged 1 commit into from
Oct 23, 2023
Merged

refactor: sync with axon new start commands #333

merged 1 commit into from
Oct 23, 2023

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Sep 26, 2023 •
edited
Loading

Description

  1. sync with latest version of axon (10.23), the start process has changed
  2. upgrade crate axon-tools
    • sync with latest version of axon (10.23), data structures like Block, Proof, Proposal has changed
    • verfiy_proof api used for block verfication updated
    • verify_trie_proof api used for tx verfication enabled and updated

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Flouse
Flouse requested changes Sep 26, 2023
View reviewed changes
.github/workflows/ibc-test.yaml Outdated Show resolved Hide resolved
@Flouse Flouse self-requested a review October 7, 2023 09:20
@Flouse Flouse requested a review from jjyr October 16, 2023 03:54
@Flouse Flouse requested a review from ashuralyk October 16, 2023 03:54
Flouse
Flouse previously requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to use the latest release of Axon.
@wenyuanhust

@ashuralyk
Copy link
Contributor

when we upgrade axon-tools dependency, the matched axon binary should be initialed with its new start command, so if we plan to test it in CI after the integration of axon-tools, this PR is needed to merge

@ashuralyk ashuralyk requested a review from Flouse October 23, 2023 10:22
@ashuralyk ashuralyk mentioned this pull request Oct 23, 2023
Closed
@wenyuanhust wenyuanhust marked this pull request as ready for review October 23, 2023 10:44
@wenyuanhust wenyuanhust dismissed Flouse’s stale review October 23, 2023 14:25

axon is now the latest release (10.23).

@wenyuanhust wenyuanhust added this pull request to the merge queue Oct 23, 2023
Merged via the queue into synapseweb3:main with commit 6dc8eee Oct 23, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@ashuralyk ashuralyk ashuralyk approved these changes

@jjyr jjyr Awaiting requested review from jjyr

@Flouse Flouse Awaiting requested review from Flouse

Assignees

@wenyuanhust wenyuanhust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenyuanhust @ashuralyk @Flouse @blckngm