feat(discard): add new cell_emitter feature with cell filter feature on and he… #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flouse this PR can start to review |
added 8 commits
November 7, 2023 15:31
…ader filter feature off
ashuralyk
force-pushed
the
feat/cell-emitter
branch
from
29bfa52
to
4156363
Compare
Flouse
reviewed
Nov 7, 2023
blckngm
reviewed
Nov 7, 2023
| | OwnableIBCHandlerEvents::WriteAcknowledgementFilter(_) | ||
| ContractEvents::SendPacketFilter(_) | ||
| | ContractEvents::WriteAcknowledgementFilter(_) | ||
| | ContractEvents::RegisterCellEmitterFilterFilter(_) |
There was a problem hiding this comment.
- How and when are these events emitted?
- What about previously registered filters?
- What's the significance of storing these filters on chain? (What's the difference with e.g. storing them offchain in a db?)
- Are all cells that we are interested in guaranteed to be emitted? Are they guaranteed to be emitted before the relavant ibc event is relayed?
There was a problem hiding this comment.
here's the answers:
- this event filter is set to filter events before starting Axon's monitor
- previous filters can be found on-chain though search prior blocks of Axon, but only accept 25000 blocks ago, filters registered before this range cannot be replayed
- filters are not stored on chain for current solidity implementation, and I don't suggest to bring off-chain db to relayer, it shouldn't keep status
- yes, almost all of cells except AckPacket cell
Co-authored-by: Flouse <[email protected]>
jjyr
approved these changes
Nov 8, 2023
|
@jjyr do you know why CI test between two Axon nodes taking so long that killed by Action |
ashuralyk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
Forcerelay should integrate
cell-emitterto enable CKB header and cell sync featuretodo list
cell-emitterand Axonrelated PRs
need further discussion
Axon seems to change its security assumption on integration of
cell-emitterabout the header and cell relaying @Flouse