-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor the monitor and transaction assembly #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
reviewed
Nov 8, 2023
ashuralyk
force-pushed
the
feat/resend-ckb-tx
branch
from
November 9, 2023 01:28
8e835df
to
7fce530
Compare
@Flouse this PR can start review again |
Flouse
reviewed
Nov 14, 2023
Flouse
approved these changes
Nov 14, 2023
Flouse
reviewed
Nov 15, 2023
Flouse
approved these changes
Nov 15, 2023
Co-authored-by: Flouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
We found the running Forcerelay faces two major problems, which are about the stability of monitor and transaction sending feature.
Monitor of Axon has an unstable problem about the disconnection in logs listener, it frequently missed essential events from Axon which will block the entire relay process.
Transaction assembly in CKB could take
RBF
andUnknowOutpoint
problems, which are caused by the cell compete, and to solve the compete condition should put huge effort on redesigning the structure of IBC cells, so as the best method is to resend unworkable transactions.change logs
retry
featureclosed PRs
forcerelay-ckb-sdk
generating tx at the same time #373