Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the monitor and transaction assembly #377

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

ashuralyk
Copy link
Contributor

@ashuralyk ashuralyk commented Nov 8, 2023

background

We found the running Forcerelay faces two major problems, which are about the stability of monitor and transaction sending feature.

Monitor of Axon has an unstable problem about the disconnection in logs listener, it frequently missed essential events from Axon which will block the entire relay process.

Transaction assembly in CKB could take RBF and UnknowOutpoint problems, which are caused by the cell compete, and to solve the compete condition should put huge effort on redesigning the structure of IBC cells, so as the best method is to resend unworkable transactions.

change logs

  1. refactor transaction assembly process in CKB to add retry feature
  2. optimize message convertor of CKB to fetch live IBC cells immediately once miss the peak in corresponding cells cache, because if retry the assembly of transaction, it should rerun the assembly process which would kick out dead cells from caches
  3. refactor monitor logic of Axon to use POLL process to take place of the LISTEN process

closed PRs

@ashuralyk
Copy link
Contributor Author

@Flouse this PR can start review again

@ashuralyk ashuralyk added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit ef6bace Nov 15, 2023
29 checks passed
@blckngm blckngm deleted the feat/resend-ckb-tx branch December 8, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC Cell conflict of relayer and forcerelay-ckb-sdk generating tx at the same time
3 participants