feat: map ics20 denoms to erc20 #23
Conversation
And don't revert on unknown denom
| // Deploy an ERC20 contract for each (sink zone) denom seen. | ||
| if (address(denomTokenContract[denom]) == address(0)) { | ||
| string memory name = string.concat("IBC/", hexEncode(abi.encodePacked(sha256(bytes(denom))))); | ||
| denomTokenContract[denom] = new ERC20PresetMinterPauser(name, ""); |
There was a problem hiding this comment.
how to associate this non-human-readable token name with a human-readable token name, like ETC, BTC, etc.
There was a problem hiding this comment.
It's a concern for UI/explorer etc. Cosmos uses https://github.com/cosmos/chain-registry.
There was a problem hiding this comment.
Or the allowlist version allows setting custom token name, symbol and decimal.
There was a problem hiding this comment.
Why do not set symbol for the ERC20?
There was a problem hiding this comment.
What should the symbol be?
There was a problem hiding this comment.
I am no sure if we can use denom as the symbol, but use an empty string is strange
There was a problem hiding this comment.
I am no sure if we can use
denomas the symbol, but use an empty string is strange
it's not an empty string, but just an encoded string which isn't recognized for human-beings and differs from symbol of ERC20, like BTC, ETH, and so on
There was a problem hiding this comment.
I understand the first arg.
denomTokenContract[denom] = new ERC20PresetMinterPauser(name, "");I am discussing the second one here
| // Deploy an ERC20 contract for each (sink zone) denom seen. | ||
| if (address(denomTokenContract[denom]) == address(0)) { | ||
| string memory name = string.concat("IBC/", hexEncode(abi.encodePacked(sha256(bytes(denom))))); | ||
| denomTokenContract[denom] = new ERC20PresetMinterPauser(name, ""); |
There was a problem hiding this comment.
Why do not set symbol for the ERC20?
No description provided.