feat: implement verifyMembership #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyuanhust
force-pushed
the
master
branch
2 times, most recently
from
194c866
to
72ffec4
Compare
|
is it ok to review? |
yes |
blckngm
reviewed
Dec 7, 2023
blckngm
reviewed
Dec 7, 2023
|
compile test failed |
the test case has some bugs, still works on it. please review solidity code firstly |
Flouse
reviewed
Dec 11, 2023
wenyuanhust
force-pushed
the
master
branch
4 times, most recently
from
f1abe07
to
252f638
Compare
wenyuanhust
force-pushed
the
master
branch
2 times, most recently
from
b299e2c
to
1529cd7
Compare
blckngm
reviewed
Dec 15, 2023
blckngm
reviewed
Dec 15, 2023
blckngm
reviewed
Dec 15, 2023
blckngm
reviewed
Dec 15, 2023
blckngm
reviewed
Dec 15, 2023
wenyuanhust
force-pushed
the
master
branch
8 times, most recently
from
ff31a66
to
aa84bfe
Compare
wenyuanhust
changed the title
blckngm
reviewed
Dec 18, 2023
blckngm
reviewed
Dec 18, 2023
blckngm
reviewed
Dec 18, 2023
wenyuanhust
force-pushed
the
master
branch
2 times, most recently
from
81ca025
to
2ba03e7
Compare
Flouse
requested changes
Dec 19, 2023
wenyuanhust
force-pushed
the
master
branch
3 times, most recently
from
98fbd3d
to
6d83861
Compare
blckngm
approved these changes
Dec 19, 2023
ashuralyk
approved these changes
Dec 19, 2023
Flouse
changed the title
Flouse
approved these changes
Dec 19, 2023
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement verifyMembership
For test case, I have generated proof data using test_transfer case of ibc-test.
Because only transactionsRoot is used in CkbHeader, so the mocked getTestHeader only contains valid transactionsRoot.
The test for this pr needs precompiled contracts in Axon, So the current ci won't pass due to use of standart Eth client.