chore: register ckb light client #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashuralyk
force-pushed
the
chore/enable-ckb-client
branch
from
4169ae3
to
40d0b10
Compare
ashuralyk
force-pushed
the
chore/enable-ckb-client
branch
3 times, most recently
from
e0eccef
to
5f28cfe
Compare
blckngm
approved these changes
Dec 21, 2023
ashuralyk
force-pushed
the
chore/enable-ckb-client
branch
from
5f28cfe
to
3ae160a
Compare
wenyuanhust
approved these changes
Dec 21, 2023
* Return same client state as MockClient * Comment out verifyClientState for now
and simplify deployment a bit by making some library functions internal
Flouse
reviewed
Dec 22, 2023
| consensusStateCommitment: bytes32(""), | ||
| height: Height.Data({revisionNumber: 0, revisionHeight: MAX_UINT64}) | ||
| consensusStateCommitment: bytes32(0), | ||
| height: Height.Data({revisionNumber: 0, revisionHeight: 9999}) |
There was a problem hiding this comment.
why use 9999 as revisionHeight?
There was a problem hiding this comment.
I just copied from MockClient.
Flouse
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.