use SSO name for config-profiles block #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 81.56% 82.93% +1.36%
==========================================
Files 38 38
Lines 2723 2741 +18
==========================================
+ Hits 2221 2273 +52
+ Misses 427 383 -44
- Partials 75 85 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
config-profile-sso-name
branch
from
a9742cc to
fdb9b48
Compare
|
This is still not working, correctly because we will dump multiple SSO instances in each config block. |
synfinatic
force-pushed
the
config-profile-sso-name
branch
from
1ce65ca to
19f8157
Compare
Deal with users with multiple SSOConfig's and who use `config-profiles` command. We no longer will replace the previous config block in the ~/.aws/config file.
synfinatic
force-pushed
the
config-profile-sso-name
branch
6 times, most recently
from
bdd3a00 to
6397f79
Compare
synfinatic
force-pushed
the
config-profile-sso-name
branch
from
6397f79 to
4b100c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with users with multiple SSOConfig's and who use
config-profilescommand. We no longer will replace the previous config block in the ~/.aws/config file.