Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on Pull Requests to main #1086

Closed

Conversation

pjdotson
Copy link
Contributor

@pjdotson pjdotson commented Feb 4, 2025

Issue Pull Request

Key Information

Description

Fix an issue where Windows and macOS CI runs would not run on PRs open to main, and instead only run on pushes to main.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have added needed QA steps to the release candidate template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

Data Structures

I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:

  • Server
  • Console

API Changes

The following projects have backwards-compatible APIs:

  • Python Client
  • Server
  • TypeScript Client

Breaking Changes

@pjdotson pjdotson self-assigned this Feb 4, 2025
@pjdotson pjdotson added the ops Operational changes such as CI/CD or configuration. label Feb 4, 2025
@emilbon99
Copy link
Contributor

Please make sure that this pull request does not run pull requests from RC into main, or it does not run on pushes to RC. I'd like to avoid running duplicate CI every time we merge a PR or push to RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ops Operational changes such as CI/CD or configuration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants