Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es6 migration #23

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Es6 migration #23

merged 6 commits into from
Nov 4, 2019

Conversation

deziev
Copy link
Contributor

@deziev deziev commented Oct 28, 2019

#19
This PR contain migration to ES6. Implemented this #19 (comment)

Branch has latest updates and fixes from master

@syntaxseed syntaxseed added next to be merged This PR will likely be merged next, so others may need to rebase after that. review in progress A review of this item is underway. labels Nov 1, 2019
@syntaxseed syntaxseed merged commit ea2f80d into syntaxseed:master Nov 4, 2019
@syntaxseed
Copy link
Owner

syntaxseed commented Nov 4, 2019

Thanks for all your work on this @deziev ! This has been a learning process for me as well, first time using Webpack and NPM.

I made a few small changes to this PR before merging:

  • Added some global CONFIG variables to the index.html file so that people can perform overrides without needing a rebuild with webpack.
  • There were duplicated and useless fileystem and CustomCmd files which I removed/renamed.
  • Updated and the README and increased version # to 1.6.0.

There is now a bug #26 in the 'help' command no longer lists custom commands.

@syntaxseed
Copy link
Owner

syntaxseed commented Nov 4, 2019

My ideal for this project, is that people can include it into their website without having to use WebPack or NPM. Which means that we need a global & non-minimized way to:

  • Define the prompt anonymous function.
  • Define the initial filesystem state.
  • Customize the boot loader message.

@syntaxseed syntaxseed removed the next to be merged This PR will likely be merged next, so others may need to rebase after that. label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review in progress A review of this item is underway.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants