Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[synthesized-io/tdk#5375] Remove workaraounds for Oracle database #109

Merged
merged 10 commits into from
Dec 13, 2024
Merged

[synthesized-io/tdk#5375] Remove workaraounds for Oracle database #109

merged 10 commits into from
Dec 13, 2024

Conversation

ViacheslavP
Copy link
Contributor

Changes

  • Workaround is deleted
  • Added Oracle database GHA
  • Added access to V$DATABASE

@ViacheslavP ViacheslavP requested a review from mgramin December 12, 2024 12:16
mgramin
mgramin suggested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mgramin mgramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the Knowing problems section in the README file since all problems appear to be resolved

@ViacheslavP ViacheslavP requested a review from mgramin December 13, 2024 15:07
mgramin
mgramin approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mgramin mgramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViacheslavP ViacheslavP merged commit 509d292 into main Dec 13, 2024
16 checks passed
@ViacheslavP ViacheslavP deleted the feature/tdk/5375-remove-tdk-demo-workaround branch December 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgramin mgramin mgramin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViacheslavP @mgramin