Merge pull request #492 from danwillm/inverse-bind-matrix

Make inverseBindMatrices optional
syoyo · Jul 3, 2024 · cfbec35 · cfbec35
2 parents cf97676 + 4ad8c82
commit cfbec35
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/tests/issue-492.glb b/tests/issue-492.glb
diff --git a/tests/tester.cc b/tests/tester.cc
@@ -1182,3 +1182,21 @@ TEST_CASE("images-as-is", "[issue-487]") {
     }
   }
 }
+
+TEST_CASE("inverse-bind-matrices-optional", "[issue-492]") {
+  tinygltf::Model model;
+  tinygltf::TinyGLTF ctx;
+  std::string err;
+  std::string warn;
+
+  bool ret = ctx.LoadBinaryFromFile(&model, &err, &warn, "issue-492.glb");
+  if (!warn.empty()) {
+    std::cout << "WARN:" << warn << std::endl;
+  }
+  if (!err.empty()) {
+    std::cerr << "ERR:" << err << std::endl;
+  }
+
+  REQUIRE(true == ret);
+  REQUIRE(err.empty());
+}
diff --git a/tiny_gltf.h b/tiny_gltf.h
@@ -5660,7 +5660,7 @@ static bool ParseSkin(Skin *skin, std::string *err, const detail::json &o,
   skin->skeleton = skeleton;
 
   int invBind = -1;
-  ParseIntegerProperty(&invBind, err, o, "inverseBindMatrices", true, "Skin");
+  ParseIntegerProperty(&invBind, err, o, "inverseBindMatrices", false, "Skin");
   skin->inverseBindMatrices = invBind;
 
   ParseExtrasAndExtensions(skin, err, o,