Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C4267 warnings in Visual Studio on WIN32 #481

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jam3sward
Copy link
Contributor

This branch fixes C4267 warnings in Visual Studio 2022 on WIN32 when compiling with warning level 4.
It replaces int with size_t and removed the various casts. It appears that all the places that were using Get were already using it with unsigned values.

@syoyo syoyo merged commit ed3d1ec into syoyo:release Mar 25, 2024
8 checks passed
@syoyo
Copy link
Owner

syoyo commented Mar 25, 2024

Thanks! Merged!

I have no idea why I did use int for Get...

@jam3sward jam3sward deleted the fix-c4267-warnings-vs-win32 branch March 26, 2024 08:45
@jam3sward
Copy link
Contributor Author

Thanks, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants