Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking and displaying errors #3

Open
evaxliu opened this issue Nov 15, 2023 · 5 comments
Open

Error checking and displaying errors #3

evaxliu opened this issue Nov 15, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request grammar Antimony grammar changes
Milestone

Comments

@evaxliu
Copy link
Collaborator

evaxliu commented Nov 15, 2023

We have the errors and error positions retrieved from parsing the model.
Next, we will display the errors through a red squiggly and also include hover information.

@evaxliu evaxliu added enhancement New feature or request grammar Antimony grammar changes labels Nov 15, 2023
@evaxliu evaxliu added this to the MVP Release milestone Nov 15, 2023
@evaxliu
Copy link
Collaborator Author

evaxliu commented Nov 29, 2023

Managed to obtain errors from the parser and display. See below:
image

Now working on making the error's hover position more accurate and disabling regular hover for the positions with errors.

  • Realized that there might not be regular hovers for the errors. I will probably isolate the error hover implementation from the regular hover implementation. I will have to figure out how to accurately determine the start and end position of these errors. (Returns the start column to the end of the line rather than having an accurate end column). See below:
    image

@evaxliu
Copy link
Collaborator Author

evaxliu commented Dec 12, 2023

Considering approaching error checking similar to vscode-antimony. We have grammar checks but not semantic ones. We can create an analysis.py type file in typescript which reads through the parse tree again and creates any error hovers based off of the rules defined in a types.py file which we should also create in typescript for this project.

@evaxliu
Copy link
Collaborator Author

evaxliu commented Dec 19, 2023

https://tellurium.readthedocs.io/en/latest/antimony.html
Documentation of rules for antimony langauge

@evaxliu
Copy link
Collaborator Author

evaxliu commented Dec 20, 2023

@evaxliu evaxliu assigned Edih112 and unassigned konankisa and evaxliu Jan 16, 2024
@Edih112
Copy link
Collaborator

Edih112 commented Jan 19, 2024

https://github.com/sys-bio/antimony/blob/develop/src/enums.h
https://github.com/sys-bio/antimony/blob/develop/src/variable.cpp#L743

Working on carrying over all of the defined types in enums.h into the symbol tables.

@Edih112 Edih112 linked a pull request Mar 11, 2024 that will close this issue
@Edih112 Edih112 removed a link to a pull request Mar 19, 2024
@Edih112 Edih112 linked a pull request Mar 25, 2024 that will close this issue
@Edih112 Edih112 removed a link to a pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grammar Antimony grammar changes
Projects
None yet
Development

No branches or pull requests

3 participants